cider-2: init at 2.5.0 #347363
Merged
cider-2: init at 2.5.0 #347363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
NixOSInfra
added
the
12. first-time contribution
itsvic-dev
force-pushed
the
cider-2-init
branch
from
eafbda8 to
a09ddb1
Compare
|
moved the package definition to pkgs/by-name as suggested by nixpkgs-vet. |
ofborg
bot
added
8.has: package (new)
Aleksanaa
reviewed
Oct 27, 2024
itsvic-dev
force-pushed
the
cider-2-init
branch
from
a09ddb1 to
347cac9
Compare
itsvic-dev
force-pushed
the
cider-2-init
branch
from
347cac9 to
91821f6
Compare
|
applied the suggestions and rebased to latest master (71ccc3b) |
|
I'd assume it works on your end. Please verify it still works. |
|
indeed it does still work, resulting in store path |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cider 2 is a third-party client for Apple Music, available for purchase via itch.io and Microsoft Store (Windows-only).
https://cider.sh/
(sorry about accidentally touching the formatting of another maintainer's keys, I have autoformatting enabled in my code editor)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.